seems cause cri-o build fail

@dimstar_suse, @factory-repo-checker: review reminder

maxlin_factory (Yuchen Lin): Thanks for the report. Can you provide additional details to reproduce? Is there an OBS build log I can look at? I am able to osc build devel:kubic/cri-o on TW x86_64 with go1.11 and this version of the go metapackage installed.

One potential issue for local builds is the current go.sh mechanism that sets go env vars:

https://build.opensuse.org/package/view_file/devel:languages:go/go1.11/go.sh?expand=1

Which the go1.11 package installs to:

$ find $GOROOT -name go.sh /usr/lib64/go/1.11/bin/profile.d/go.sh

$ sudo find /etc/ -name go.sh /etc/alternatives/go.sh /etc/profile.d/go.sh

The correct env vars set by go.sh should be:

$ set |grep GO GOARCH=amd64 GOOS=linux GOPATH=/home/myuser/go:/usr/share/go/1.11/contrib GOROOT=/usr/lib64/go/1.11

After installing go1.11 on my machine, the previous setting persisted GOROOT=/usr/lib64/go/1.10 despite opening new shells during troubleshooting. IIRC once I exited my tmux session, the correct version of go.sh and correct env vars were used thereafter. I don't know the reason I was seeing that behavior w.r.t. /etc/profile.d/go.sh.

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:J/cri-o/standard/x86_64

I have a patch for cri-o-1.11.2 backporting one hunk from an upstream commit that fixes go1.11 compatibility.

Upstream: "cleanup new errors found by improved compiler" https://github.com/kubernetes-sigs/cri-o/commit/0bd30872028b5ed2d0eb7febb39f034b5f2da72a

Request https://build.opensuse.org/request/show/640141 containing the fix submitted to devel:kubic/cri-o.

Related: request with point update to go1.11.1 submitted: https://build.opensuse.org/request/show/640142