Overview
Request 638972 superseded
- Accept after request 638969 adding go1.11 packages to Factory
- Fix stray 1.10 version reference preventing 1.11 only package solutions
- Update to version 1.11:
* Most of its changes are in the implementation of the toolchain,
runtime, and libraries. As always, the release maintains the
Go 1 promise of compatibility. We expect almost all Go programs
to continue to compile and run as before.
* For more details check: https://golang.org/doc/go1.11
- Use gcc8 instead of gcc7 for Factory/Tumbleweed.
- Update compiler-rt TSAN binary: the precompiled versions of
LLVM's compiler-rt has updated to commit
fe2c72c59aa7f4afa45e3f65a5d16a374b6cce26 in go1.11 source.
- Remove patch:
* fix-sanitizer-build-against-latest-glibc.patch: upstream fixed.
- Add patch:
* gcc8-go.patch: use gcc8 instead of gcc7 for Factory/Tumbleweed.
- Update to version 1.10.4:
* go1.10.4 (released 2018/08/24) includes fixes to the go command,
linker, and the net/http, mime/multipart, ld/macho, bytes, and
strings packages. See the Go 1.10.4 milestone on our issue
tracker for details.
- Created by jfkw
- In state superseded
- Superseded by 640330
-
Open review for
repo-checker
- Open review for openSUSE:Factory:Staging:J
Request History
jfkw created request
- Accept after request 638969 adding go1.11 packages to Factory
- Fix stray 1.10 version reference preventing 1.11 only package solutions
- Update to version 1.11:
* Most of its changes are in the implementation of the toolchain,
runtime, and libraries. As always, the release maintains the
Go 1 promise of compatibility. We expect almost all Go programs
to continue to compile and run as before.
* For more details check: https://golang.org/doc/go1.11
- Use gcc8 instead of gcc7 for Factory/Tumbleweed.
- Update compiler-rt TSAN binary: the precompiled versions of
LLVM's compiler-rt has updated to commit
fe2c72c59aa7f4afa45e3f65a5d16a374b6cce26 in go1.11 source.
- Remove patch:
* fix-sanitizer-build-against-latest-glibc.patch: upstream fixed.
- Add patch:
* gcc8-go.patch: use gcc8 instead of gcc7 for Factory/Tumbleweed.
- Update to version 1.10.4:
* go1.10.4 (released 2018/08/24) includes fixes to the go command,
linker, and the net/http, mime/multipart, ld/macho, bytes, and
strings packages. See the Go 1.10.4 milestone on our issue
tracker for details.
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
jengelh accepted review
staging-bot set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
staging-bot accepted review
Picked openSUSE:Factory:Staging:B
maxlin_factory accepted review
Removing from openSUSE:Factory:Staging:B, re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
maxlin_factory set openSUSE:Factory:Staging:J as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:J"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:J
superseded by 640330
seems cause cri-o build fail
@dimstar_suse, @factory-repo-checker: review reminder
maxlin_factory (Yuchen Lin): Thanks for the report. Can you provide additional details to reproduce? Is there an OBS build log I can look at? I am able to osc build devel:kubic/cri-o on TW x86_64 with go1.11 and this version of the go metapackage installed.
One potential issue for local builds is the current go.sh mechanism that sets go env vars:
https://build.opensuse.org/package/view_file/devel:languages:go/go1.11/go.sh?expand=1
Which the go1.11 package installs to:
$ find $GOROOT -name go.sh /usr/lib64/go/1.11/bin/profile.d/go.sh
$ sudo find /etc/ -name go.sh /etc/alternatives/go.sh /etc/profile.d/go.sh
The correct env vars set by go.sh should be:
$ set |grep GO GOARCH=amd64 GOOS=linux GOPATH=/home/myuser/go:/usr/share/go/1.11/contrib GOROOT=/usr/lib64/go/1.11
After installing go1.11 on my machine, the previous setting persisted GOROOT=/usr/lib64/go/1.10 despite opening new shells during troubleshooting. IIRC once I exited my tmux session, the correct version of go.sh and correct env vars were used thereafter. I don't know the reason I was seeing that behavior w.r.t. /etc/profile.d/go.sh.
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:J/cri-o/standard/x86_64
I have a patch for cri-o-1.11.2 backporting one hunk from an upstream commit that fixes go1.11 compatibility.
Upstream: "cleanup new errors found by improved compiler" https://github.com/kubernetes-sigs/cri-o/commit/0bd30872028b5ed2d0eb7febb39f034b5f2da72a
Request https://build.opensuse.org/request/show/640141 containing the fix submitted to devel:kubic/cri-o.
Related: request with point update to go1.11.1 submitted: https://build.opensuse.org/request/show/640142