Request 582655 (accepted)

This request supersedes: request 582386 (Show diff)

Overview

Request 582655 accepted

Hi Antonio,

thanks for catching this.

While at it, I tagged your patch, and...

- fix sphinx theme fallback condition

- apply patch to fall back to a sphinx default theme for older distributions,
that haven't python3-guzzle_sphinx_theme available

Created by frispete about 6 years ago
In state accepted
Package maintainers: alarrosa, frispete, and kbabioch
Supersedes 582386

Submit borgbackup

Comments for request 582655 0
Comments for request 582386 1

Antonio Larrosa (alarrosa) - about 6 years ago

target maintainer

Thanks for the patch! Just one small issue. Since you're using that %else to apply it, it's being applied on Leap 15, where it's not needed. Could you change it to use its own condition and only apply the patch when %{suse_version} < 1500 ?

Request History

frispete created request about 6 years ago

Hi Antonio,

thanks for catching this.

While at it, I tagged your patch, and...

- fix sphinx theme fallback condition

- apply patch to fall back to a sphinx default theme for older distributions,
that haven't python3-guzzle_sphinx_theme available

alarrosa accepted request about 6 years ago

Cool, thanks!

Places

Overview