Overview
Request History
anubisg1 created request
Fixed license tag to GPL-2.0+
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger added legal-team as a reviewer
{"delegate": "new package ldb.risk is None"}
licensedigger accepted review
{"delegate": "new package ldb.risk is None"}
factory-repo-checker accepted review
Builds for repo X11:lxde/openSUSE_Factory
babelworx accepted review
mlin7442 accepted review
No need for staging, not in tested ring projects.
dimstar declined review
+%files -n libfm-qt5-1
+%defattr(-,root,root)
+%{_libdir}/libfm-qt5.so.*
+%{_datadir}/libfm-qt
This package violoates the SLPP. Bu having an unversioned directory you undermine the possibility of installing the library with multiple ABI versions.
rpmlint hints at that as well: libfm-qt5-1.i586: W: shlib-policy-nonversioned-dir /usr/share/libfm-qt
dimstar declined request
+%files -n libfm-qt5-1
+%defattr(-,root,root)
+%{_libdir}/libfm-qt5.so.*
+%{_datadir}/libfm-qt
This package violoates the SLPP. Bu having an unversioned directory you undermine the possibility of installing the library with multiple ABI versions.
rpmlint hints at that as well: libfm-qt5-1.i586: W: shlib-policy-nonversioned-dir /usr/share/libfm-qt
anubisg1 reopened request
that folder includes only translations which are specific for that library. this is a path used upstream and doesn't make any sense to split a -lang package for the library i think.
dimstar accepted review
Same mess as with Qt4 libs; they don't do ABI bumps anyway (SLPP makes only half-baked sense here)
dimstar approved review
Same mess as with Qt4 libs; they don't do ABI bumps anyway (SLPP makes only half-baked sense here)
coolo accepted request
Accept to Factory
