Fast, simple and secure messaging app from your desktop
https://github.com/signalapp/Signal-Desktop/
Signal Desktop is an Electron application that links with your Signal Android
or Signal iOS app.
- Sources inherited from project network:im:signal
-
5
derived packages
- Download package
-
Checkout Package
osc -A https://api.opensuse.org checkout home:dziobian:gulgul-ultron:19/signal-desktop && cd $_ - Create Badge
Refresh
Refresh
Source Files
Latest Revision
i thod (ithod)
accepted
request 1170281
from
Bruno Pitrus (dziobian)
(revision 297)
- New upstream release 7.6.0
* no changelog provided
* Migrate to database schema version 1030.
It is NOT POSSIBLE to downgrade Signal if you have started it after this update!
Comments 12
Do you know how often electron makes ABI-breaking changes? If minor updates are OK, it might be worth doing something like this:
Requires: nodejs-electron%{?_isa} >= %{electron_req_version}
Requires: nodejs-electron%{?_isa} < 17 (or whatever is current version + 1)
My Bitwarden binaries built with Electron 13 ( https://build.opensuse.org/package/show/home:dziobian:gulgul-ultron/bitwarden ) work fine on 16, but Signal does not, so there seem to be at least two types of binary Node modules.
Signal requires header files for electron which are being downloaded. Same for nodejs, so the header files in the vendor tarball need to match exactly the nodejs and electron version to be able to build it.
Yes, it is quite a mess.
The nodejs headers are provided in nodejs16-devel and can be used adding --nodedir=/usr/include/node16 to npm command line. Unfortunately the SuSE distribution of electron does not include devel headers. Ouch.
My question was different tho. I was asking whether binaries built against electron 16.0.1 can run with electron 16.0.2.
Yes, that should work. I was even able to run signal-desktop built against electron 13 with electron 15. However signal-desktop build with 15 and running with 16 doesn't work. Minor version updates should work.
I will look into node includes soon. However it still downloads electron headers from the web. Maybe we can package them too.
If I do
export npm_config_nodedir=/usr/include/node16node-gyp doesn't find the header:
make: Entering directory '/tmp/signal-desktop-1Tah1oUK/Signal-Desktop-5.29.0/node_modules/fs-xattr/build' CC(target) Release/obj.target/xattr/src/async.o In file included from ../src/async.c:6: ../src/error.h:5:10: fatal error: node_api.h: No such file or directory 5 | #include <node_api.h> |https://bugzilla.opensuse.org/show_bug.cgi?id=1195164
The environment variable seems to not work, you need to use
--prefix=…. See how i did it in my spec for bitwardenThat's just a workaround. I think right fix is that the common.gypi sets the include path correctly.
I also see the remove-heif support patch, that's uncool, I'll miss out on lots of dog and food pictures!
Seriously, anything that can be done to have working heif support? As disabling that means 99% of the pics I get don't show :D Or does it work and does this patch do something else... Sorry, just curious I guess.
Tell your friends to use royalty free image formats.
Thank you for your dedication and hard work! This is so much appreciated!!!
I agree. Thank you for all you do. Just out of curiosity, is anyone else having issues with spellcheck working?