Overview
Request 997441 accepted
- Implement python packaging best practices for build requirements,
testing and files section
As suggested on ML
- Created by bnavigator
- In state accepted
-
Package maintainer:
DocB
Loading...
Request History
bnavigator created request
- Implement python packaging best practices for build requirements,
testing and files section
As suggested on ML
DocB accepted request
Thank you Ben. Why did you drop the isort test? That worked flawless...
It falls into the same category as flake8 and coverage: Whether the code is formatted right w.r.t to import order is irrelevant for the rpm package.
OK, but would it not make sense to have working tests included? I'm with you regarding flake8 and the issues around modules....
It's a matter of choice. Keeping the build requirements footprint small vs. custom patching. Since flake8 is already disabled, I chose to align isort with it. Could have gone the other way and install pytest-flake8 instead. Flake8 is more prone to different results between version changes than isort, though.