Overview

Request 985052 accepted

New package

Loading...

Dead Mozay's avatar
author source maintainer target maintainer

Seems to have taken into account all your comments.


Dominique Leuenberger's avatar

Ignore my group comment - that was rpmlint in 15.4 being crazy and putting me ofg


Dominique Leuenberger's avatar
  • Using meson AND libtool/m4?

  • Do not recommend lang package: it has relevant supplements already

  • FTBFS on i586

  • Manual strip should not be needed, happens when generating debuginfo package

  • Do not declare buildtype release: makes debuginfo packages useless/difficult

  • Why no parallel build?

  • Pkgconfig(libpng) and png16?

  • Gst buildreq also seem excessive: pkgconfig and non-pkgconfig


Dead Mozay's avatar
author source maintainer target maintainer

1) m4 Needed to build gmp-mpfr-sys, use make, libtool was needed in earlier versions that I could not build, some component required, removed 2) I add because I am constantly asked why the language pack is not installed with the application itself 3) Ok 4) The change is cosmetic, rpmlit swears by warnings 5) ok, i'll take it out 6) Already added to spec why and link https://gitlab.gnome.org/World/amberol/-/issues/182 7-8) Oops! I forgot to remove it, I was looking for an error by sorting through the packages.

I'll make all the edits now.

Request History
Dead Mozay's avatar

Dead_Mozay created request

New package


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar approved review


Dominique Leuenberger's avatar

dimstar accepted request

openSUSE Build Service is sponsored by