Request 951770: Submit gnome-commander

Overview

Request 951770 accepted

- Update to version 1.14.0:
+ Selectable default action when drag-n-drop files with the mouse
+ Optional usage of the trash can instead of permanent file
deletion
+ Removed internal file search dialog, instead use external
command for file search
+ Name of connected remote server is shown in the directory
indicator
+ New menu entry for (un)selecting only files
+ Bugs fixed: glgo#GNOME/gnome-commander#3,
glgo#GNOME/gnome-commander#5, glgo#GNOME/gnome-commander#13,
glgo#GNOME/gnome-commander#16, glgo#GNOME/gnome-commander#19,
glgo#GNOME/gnome-commander#28, glgo#GNOME/gnome-commander#33,
glgo#GNOME/gnome-commander#39, glgo#GNOME/gnome-commander#41,
glgo#GNOME/gnome-commander#45, glgo#GNOME/gnome-commander#46,
glgo#GNOME/gnome-commander#47, glgo#GNOME/gnome-commander#51,
glgo#GNOME/gnome-commander#52, glgo#GNOME/gnome-commander#57,
glgo#GNOME/gnome-commander#59, glgo#GNOME/gnome-commander#74,
glgo#GNOME/gnome-commander#75, glgo#GNOME/gnome-commander#76,
glgo#GNOME/gnome-commander#107, glgo#GNOME/gnome-commander#115.
+ Updated translations.
- Add flex BuildRequires: New dependency.

Created by iznogood over 2 years ago
In state accepted

Submit gnome-commander

Comments for request 951770 6

Luciano Santos (luc14n0) - over 2 years ago

reviewer target maintainer

Hey Bjørn! If you/we want to automate the Source URL you could just toss a:

%define maj_min %(grep -oE ^[0-9]+\\.[0-9]+ <(echo %{version}))

Or something of the sort. I can't tell whether RPM's %() will like the inner parentheses or not. The good old output piping could take place, if it doesn't:

%define maj_min %(echo %{version} | grep -oE ^[0-9]+\\.[0-9]+)

Bjørn Lie (iznogood) - over 2 years ago

author reviewer

rpmlint gets "insulted" when you use macros in Version: + The second someone uses osc collab to update the package, it gets overwritten

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer target maintainer

not only rpmlint, but also the source validator

we are not executing %() in contexts of the bots (Source: https://%(rm -rf /) does not sound like something we want to run)

Luciano Santos (luc14n0) - over 2 years ago

reviewer target maintainer

Well, my idea wasn't to touch Version: tag only to put the maj_min macro in the Source tag, but if it will only get overwritten by Collab or get a "You shall not pass!" from RPM Lint or Source Validator....

Nonetheless there's a good point to summoning sub-shells with dangerous commands, I just wished not every command got the no go from those tools 8^(

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer target maintainer

Source needs to be expanded to run 'osc service ra download_files' (which is part of source validation) - having %() in there is just a no-go

Luciano Santos (luc14n0) - over 2 years ago

reviewer target maintainer

OK. Since I don't know RPM's internals when expanding macros, I was hoping that RPM would expand the macro %maj_min, that I proposed since there's a sub-shell invocation, before replacing it in the Source tag as it needs to find out its value, like:

Step 1:

%define maj_min %(grep -oE ^[0-9]+\\.[0-9]+ <(echo %{version}))
...
Source: http://download.gnome.org/sources/gnome-commander/%{maj_min}/%{name}-%{version}.tar.xz

Step 2:

%define maj_min 1.14
...
Source: http://download.gnome.org/sources/gnome-commander/%{maj_min}/%{name}-%{version}.tar.xz

And finally Step 3:

%define maj_min 1.14
...
Source: http://download.gnome.org/sources/gnome-commander/1.14/gnome-commander-1.14.0.tar.xz

So I see then it's the other way around. RPM first replaces all macros' values (even though %maj_min's real value is still unknown) before executing the sub-shell's commands.