Overview

Request 950576 accepted

- Add _constraints for docs(+test) to avoid OOM build failures
- Drop obsolete/unnecessary patches
* eigen3-3.3.1-fixcmake.patch (no longer has any effect)
* 01_install_FindEigen3.patch (CMake Config mode is preferred)
- Fix build for ppc64le (affects test and dependent packages, e.g.
arpack-ng), add fix_ppc64le_always_inline_680.patch

Atri Bhattacharya's avatar
Atri Bhattacharya (badshah400) -
target maintainer

Can you please clarify your changelog entry:

  • 01_install_FindEigen3.patch (CMake Config mode is preferred)

From the cmake manual:

Config mode

In this mode, CMake searches for a file called <lowercasePackageName>-config.cmake or <PackageName>Config.cmake.

However, since eigen installs no such cmake files, how would it work when cmake, e.g. invoked when building another app, tries to find it?

Thanks for any clarification.

Stefan Brüns's avatar
Stefan Brüns (StefanBruens) -
author source maintainer target maintainer

It installs /usr/share/eigen3/cmake/Eigen3Config.cmake

Stefan Brüns's avatar
Stefan Brüns (StefanBruens) -
author source maintainer target maintainer

https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure

<prefix>/(lib/<arch>|lib*|share)/<name>*/(cmake|CMake)/ (U)

In all cases the <name> is treated as case-insensitive and corresponds to any of the names specified (<PackageName> or names given by NAMES).

The path given matches this pattern.

Atri Bhattacharya's avatar
Atri Bhattacharya (badshah400) -
target maintainer

Yes, sorry I overlooked that. Many thanks.

Stefan Brüns's avatar
Stefan Brüns (StefanBruens) -
author source maintainer target maintainer

No worries, you do a great job here!

Request History
Stefan Brüns's avatar

StefanBruens created request

- Add _constraints for docs(+test) to avoid OOM build failures
- Drop obsolete/unnecessary patches
* eigen3-3.3.1-fixcmake.patch (no longer has any effect)
* 01_install_FindEigen3.patch (CMake Config mode is preferred)
- Fix build for ppc64le (affects test and dependent packages, e.g.
arpack-ng), add fix_ppc64le_always_inline_680.patch

Atri Bhattacharya's avatar

badshah400 accepted request

Big thanks.

openSUSE Build Service is sponsored by
Places