Overview

Request 944747 accepted

- Update to version 0.0.5~git0.bbb5544:
* Switch from rubygem-ffi to fiddle
* Cleanup services during migration (bsc#1161891)
* Allow non-root users to see usage text
* Add option to not fail dup as much
* Move APIVersion declaration to file where it is used
* Add flag to enable/disable hwinfo test
* Add ARM cluster count to hwinfo and fix test
* Simplify parsing JSON error response
* Add --gpg-auto-import-keys for zypper ref
* Rename main.go to logging.go
* Fix typo
* Remove init() from the connect package
* Move CFG variable declaration to config.go
* Move AppName const to the file where it is used
* Use testing.Helper() in test helpers
* Add ppc64le support
* Disable UUID test
* Add test tools to BuildRequires
* Ignore UUID errors
* Run basic hwinfo sanity test on build service
* Update code comments to match shim behavior.
* Remove dependency on systemd
* Only run httputil DumpResponse when needed


Dominique Leuenberger's avatar

36+BuildRequires: systemd

Preferably would be pkgconfig(systemd) (which allows OBS to shortcut through systemd-mini)

52+Recommends: systemd

Makes not much sense for a package to recommend usage of any particular init system. The system decides on the init system


Jan Zerebecki's avatar

Both are there because we use the binary systemd-detect-virt, we do not need that init system or anything else from systemd. AFAIK that means we should not use pkgconfig(...) as that is only for requiring a library.


Dominique Leuenberger's avatar

pkgconfig(systemd) is a symbol provided by the systemd package (and systemd-mini)

pkgconfig(libsystemd) would be for the libraries

Request History
Jan Zerebecki's avatar

jzerebecki created request

- Update to version 0.0.5~git0.bbb5544:
* Switch from rubygem-ffi to fiddle
* Cleanup services during migration (bsc#1161891)
* Allow non-root users to see usage text
* Add option to not fail dup as much
* Move APIVersion declaration to file where it is used
* Add flag to enable/disable hwinfo test
* Add ARM cluster count to hwinfo and fix test
* Simplify parsing JSON error response
* Add --gpg-auto-import-keys for zypper ref
* Rename main.go to logging.go
* Fix typo
* Remove init() from the connect package
* Move CFG variable declaration to config.go
* Move AppName const to the file where it is used
* Use testing.Helper() in test helpers
* Add ppc64le support
* Disable UUID test
* Add test tools to BuildRequires
* Ignore UUID errors
* Run basic hwinfo sanity test on build service
* Update code comments to match shim behavior.
* Remove dependency on systemd
* Only run httputil DumpResponse when needed


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:D as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:D got accepted.

openSUSE Build Service is sponsored by