Overview

Request 933083 superseded

JFYI: this is planned as update also for SLE12 and SLE15.
Please have a closer look, not that I missed something.
As the plugins are in productive use on monitor.opensuse.org, I
do not expect big issues. But the dhcpd plugin was not extensively tested, yet.

- recommend syslog for monitoring-plugins-log, as people probably
want to analize logs generated by (r)syslog or journald
Renamed patches:
- renamed monitoring-plugins-1.4.6-no_chown.patch to
monitoring-plugins-1.4.6-Makefile_-_no_chown.patch to make it
easier to detect the patched file
- renamed monitoring-plugins-2.1.1-check_logfile.patch to
monitoring-plugins-2.1.1-check_log_-_quoting.patch to make it
easier to detect the patched file and reason for the patch
New patches:
- add monitoring-plugins-2.3.1-check_snmp_segfaults.patch:
check_snmp will segfaults at line 489 if number of lines returned
by SNMPD is greater than number of defined thresholds
-> https://github.com/monitoring-plugins/monitoring-plugins/pull/1589
- added monitoring-plugins-2.3.1_-_check_snmp_hang_on_STDERR_workaround.patch:
When the MIBs are not quite right, snmpget outputs lots of errors on
STDERR before getting down to business.
If this is enough to fill the pipe buffer, snmpget hangs waiting for
it to be cleared, which it never will be because check_snmp is
waiting for snmpget to output something on STDOUT.
This simple fix from s2156945 for this is to read STDERR before STDOUT.
cmd_run_array from utils_cmd.c is also used by plugins/check_by_ssh
and plugins/negate but you're likely to get lots of errors or lots
of output, not both at the same time.
The real fix is probably to do a select() and read from both as
they come in.
https://github.com/monitoring-plugins/monitoring-plugins/issues/1706
- added monitoring-plugins-2.3.1-check_dhcp_-_detect_rogue_dhcp_servers.patch:
feature enhancement from Patrick Cervicek for check_dhcp, which allows
to detect rogue DHCP servers. Use it with the "-x" flag, example:

Request History
Lars Vogdt's avatar

lrupp created request

JFYI: this is planned as update also for SLE12 and SLE15.
Please have a closer look, not that I missed something.
As the plugins are in productive use on monitor.opensuse.org, I
do not expect big issues. But the dhcpd plugin was not extensively tested, yet.

- recommend syslog for monitoring-plugins-log, as people probably
want to analize logs generated by (r)syslog or journald
Renamed patches:
- renamed monitoring-plugins-1.4.6-no_chown.patch to
monitoring-plugins-1.4.6-Makefile_-_no_chown.patch to make it
easier to detect the patched file
- renamed monitoring-plugins-2.1.1-check_logfile.patch to
monitoring-plugins-2.1.1-check_log_-_quoting.patch to make it
easier to detect the patched file and reason for the patch
New patches:
- add monitoring-plugins-2.3.1-check_snmp_segfaults.patch:
check_snmp will segfaults at line 489 if number of lines returned
by SNMPD is greater than number of defined thresholds
-> https://github.com/monitoring-plugins/monitoring-plugins/pull/1589
- added monitoring-plugins-2.3.1_-_check_snmp_hang_on_STDERR_workaround.patch:
When the MIBs are not quite right, snmpget outputs lots of errors on
STDERR before getting down to business.
If this is enough to fill the pipe buffer, snmpget hangs waiting for
it to be cleared, which it never will be because check_snmp is
waiting for snmpget to output something on STDOUT.
This simple fix from s2156945 for this is to read STDERR before STDOUT.
cmd_run_array from utils_cmd.c is also used by plugins/check_by_ssh
and plugins/negate but you're likely to get lots of errors or lots
of output, not both at the same time.
The real fix is probably to do a select() and read from both as
they come in.
https://github.com/monitoring-plugins/monitoring-plugins/issues/1706
- added monitoring-plugins-2.3.1-check_dhcp_-_detect_rogue_dhcp_servers.patch:
feature enhancement from Patrick Cervicek for check_dhcp, which allows
to detect rogue DHCP servers. Use it with the "-x" flag, example:


Factory Auto's avatar

factory-auto declined review

Output of check script:
A patch (monitoring-plugins-2.3.1-check_snmp_hang_on_STDERR_workaround.patch) is being added without this addition being mentioned in the changelog.
A patch (monitoring-plugins-2.3.1-check_ssh.t_-_improve_testing.patch) is being added without this addition being mentioned in the changelog.


Factory Auto's avatar

factory-auto declined request

Output of check script:
A patch (monitoring-plugins-2.3.1-check_snmp_hang_on_STDERR_workaround.patch) is being added without this addition being mentioned in the changelog.
A patch (monitoring-plugins-2.3.1-check_ssh.t_-_improve_testing.patch) is being added without this addition being mentioned in the changelog.


Lars Vogdt's avatar

lrupp superseded request

superseded by 933139

openSUSE Build Service is sponsored by