Request 930522 (accepted)

Overview

Request 930522 accepted

- Update to release 70.1:

Created by jengelh over 2 years ago
In state accepted

Submit icu

Comments for request 930522 6

Dominique Leuenberger (dimstar_suse) - over 2 years ago

reviewer target maintainer

Breaks python-PyICU

Dominique Leuenberger (dimstar_suse) - over 2 years ago

reviewer target maintainer

Unignored: returned to active backlog.

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

Breaks php7:

[  238s] /home/abuild/rpmbuild/BUILD/php-7.4.25/ext/intl/timezone/timezone_methods.cpp:536:37: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
[  238s]   536 |         for (int i = 0; !found && i < sizeof(display_types)/sizeof(*display_types); i++) {
[  238s]       |                                   ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[  238s] In file included from /home/abuild/rpmbuild/BUILD/php-7.4.25/ext/intl/breakiterator/breakiterator_class.cpp:23:
[  238s] /home/abuild/rpmbuild/BUILD/php-7.4.25/ext/intl/breakiterator/codepointiterator_internal.h:42:31: error: conflicting return type specified for 'virtual UBool PHP::CodePointBreakIterator::operator==(const icu_70::BreakIterator&) const'
[  238s]    42 |                 virtual UBool operator==(const BreakIterator& that) const;
[  238s]       |                               ^~~~~~~~
[  238s] In file included from /home/abuild/rpmbuild/BUILD/php-7.4.25/ext/intl/breakiterator/breakiterator_class.cpp:21:
[  238s] /usr/include/unicode/brkiter.h:127:18: note: overridden function is 'virtual bool icu_70::BreakIterator::operator==(const icu_70::BreakIterator&) const'
[  238s]   127 |     virtual bool operator==(const BreakIterator&) const = 0;
[  238s]       |                  ^~~~~~~~
[  238s] /home/abuild/rpmbuild/BUILD/php-7.4.25/ext/intl/calendar/calendar_class.cpp: In function 'HashTable* Calendar_get_debug_info(zval*, int*)':
[  238s] /home/abuild/rpmbuild/BUILD/php-7.4.25/ext/intl/calendar/calendar_class.cpp:208:28: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
[  238s]   208 |                          i < sizeof(debug_info_fields) / sizeof(*debug_info_fields);
[  238s]       |                          ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[  238s] make: *** [Makefile:1118: ext/intl/breakiterator/breakiterator_class.lo] Error 1

CC @elvigia, @pgajdos, @adkorte

Arjen de Korte (adkorte) - over 2 years ago

This is fixed in php-7.4.26 as far as I can see (which was released today):

---php-7.4.25.tar.xz/ext/intl/breakiterator/codepointiterator_internal.h
+++php-7.4.26.tar.xz/ext/intl/breakiterator/codepointiterator_internal.h
@@ -39,7 +39,11 @@

                 virtual ~CodePointBreakIterator();

+#if U_ICU_VERSION_MAJOR_NUM >= 70
+                virtual bool operator==(const BreakIterator& that) const;
+#else
                 virtual UBool operator==(const BreakIterator& that) const;
+#endif

                 virtual CodePointBreakIterator* clone(void) const;

It builds find with the new library.

https://build.opensuse.org/request/show/932279

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

\o/ - Staging did not test php8, but there is a high chance it will be affected too

Arjen de Korte (adkorte) - over 2 years ago

It is indeed affected (I already checked). The good news is, I have staged php-8.0.13 already, I'm just waiting for the formal release notification from upstream (should be somewhere today).

https://build.opensuse.org/request/show/932418