41+%if 0%{?sle_version} >= 150000 || 0%{?suse_version} > 1500

You can shorten that to just 0%{?suse_version} >= 1500

The split of the overlay package feels somewhat artificial, as:

%{name} requires %{name}-overlay and %{name}-overlay requires %{name} - so neither of the two packages can exist without the other one.

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

and 'them coming from the same source package' makes them not updatable separately (whenever the overlay is being built, the actual source is also built)

The main reason why the overlays is a separate package, is that the files in there can/will be modified by the user/sysadmin. As far as I know, files under /var/lib can't be fenced by the %config macro, or is this wrong?

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

Technically, there is no limitation to %config files in /var

Packages are discouraged from installing files in var by means of package though in any way, as any snapshot rollback does NOT cover var - i.e the package version and the files stored in var can be decoupled

That is not a real problem here, as the files in '/var/lib/warewulf/overlays` contain the configuration for managed nodes. When there are modifications we can consider them as important, thus we do not want to overwrite them nor have a rollback on them.