Overview

Request 920633 accepted

- Add a versioned dependency of multipath-tools on libmpath0
(bsc#1190622)


Jan Engelhardt's avatar

bug 1190622 is inaccessible! there may be a better way than to depend on libmpath0.


Martin Wilck's avatar
author source maintainer

It's a partner bug. I could open it up but it's simple: On SLE 15-SP3 or Leap 15.3, it's possible to update to multipath-tools-0.8.5+80+suse.73c50f5 without updating libmpath0, causing bad breakage.

I used to rely on the automatic dependency on libmultipath.so.0, which turned out to be insufficient in this case because I'd overlooked an API incompatibility.

On Factory we've got 0.8.6 which uses library versioning. So problems like this are unlikely to happen even without this explicit "Requires:". OTOH, libmpath0 and multipath-tools are really tied so closely together that installing different versions of the two makes no sense.

If you have a better suggestion, please inform me.


Jan Engelhardt's avatar

Well that would be my suggestion, library versioning (symvers), on all levels.

  1. If a library is missing them, a set of fixed symvers can be added (libpff.spec for an example)
  2. if a library has problematic symvers, they can be thrown out and replaced by method 1.

So then the Requires isn't needed. (rpmlint also prefers symvers over spec-level Requires)


Martin Wilck's avatar
author source maintainer

As I said, it's not strictly necessary on Factory (but on SLE/Leap). OTOH the two packages are really strictly connected (libmultipath is changing all the time and has no real public "API"). By using the Requires:, we are on the safe side and are consistent with SLE/Leap, without a negative impact on Factory.

Anyway, if you feel strongly about it, just reject this PR. In that case I'll just add a bugref to the changelog entry that introduced the library versioning.

Request History
Martin Wilck's avatar

mwilck created request

- Add a versioned dependency of multipath-tools on libmpath0
(bsc#1190622)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:E as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:E"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:E"


Saul Goodman's avatar

licensedigger accepted review

The legal review is accepted preliminary. The package may require actions later on.


Jan Engelhardt's avatar

jengelh added jengelh as a reviewer

evaluate symvers


Jan Engelhardt's avatar

jengelh accepted review


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:E got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:E got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:E got accepted.

openSUSE Build Service is sponsored by