- Use libalternatives instead of update-alternatives.
%if 0%{?suse_version} > 1500 %bcond_without libalternatives %else %bcond_with libalternatives %endif
Shouldn't it be inverted? I.e. when suse_version is greater than 1500 (i.e. it's TW), then build with libalternatives.
suse_version
To be honest I have had the same thoughts while I have taken the code from Adam, but I have tested it so often in different packages. It makes the right "thing" :;-)
Sorry for the delay. It looks good to me.
Just one thing. Should this package own the %{_datadir}/libalternatives directory?
%{_datadir}/libalternatives
@dspinella: review reminder
schubi2 created request over 2 years ago
dspinella accepted request over 2 years ago
Thank you!
dspinella
The Open Build Service is an openSUSE project.
%if 0%{?suse_version} > 1500 %bcond_without libalternatives %else %bcond_with libalternatives %endifShouldn't it be inverted? I.e. when
suse_versionis greater than 1500 (i.e. it's TW), then build with libalternatives.To be honest I have had the same thoughts while I have taken the code from Adam, but I have tested it so often in different packages. It makes the right "thing" :;-)
Sorry for the delay. It looks good to me.
Just one thing. Should this package own the
%{_datadir}/libalternativesdirectory?@dspinella: review reminder