Request 906399 (accepted)

This request supersedes: request 905261 (Show diff), request 905288 (Show diff)

Overview

Request 906399 accepted

- Use /bin/bash for sysusers-generate-pre

- Remove usage of grep from sysusers-generate-pre
- Add a simple test of sysusers-generate-pre to %check

Created by kukuk almost 3 years ago
In state accepted
Supersedes 905261 905288

Submit sysuser-tools

Comments for request 906399 0
Comments for request 905261 2

Dominique Leuenberger (dimstar) - almost 3 years ago

reviewer

#!/bin/sh
# pass systemd sysusers config paths as argument to this script.

echo "/usr/sbin/sysusers2shadow $2 <<\"EOF\" || [ -f /.buildenv ]"
(while read -r line; do if [[ $line =~ ^\s*[ugmr] ]]; then echo "$line"; fi; done) < "$1"
echo 'EOF'

[[ is not posix sh if I'm not mistaken

Jan Engelhardt (jengelh) - almost 3 years ago

reviewer

[[, =~, unquoted $2. “ah yes the … ultimate shell experience.

Request History

kukuk created request almost 3 years ago

- Use /bin/bash for sysusers-generate-pre

- Remove usage of grep from sysusers-generate-pre
- Add a simple test of sysusers-generate-pre to %check

factory-auto added opensuse-review-team as a reviewer almost 3 years ago

Please review sources

factory-auto accepted review almost 3 years ago

Check script succeeded

licensedigger accepted review almost 3 years ago

dimstar_suse set openSUSE:Factory:Staging:B as a staging project almost 3 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:B"

dimstar_suse accepted review almost 3 years ago

Picked "openSUSE:Factory:Staging:B"

dimstar accepted review almost 3 years ago

dimstar_suse accepted review almost 3 years ago

Staging Project openSUSE:Factory:Staging:B got accepted.

dimstar_suse approved review almost 3 years ago

Staging Project openSUSE:Factory:Staging:B got accepted.

dimstar_suse accepted request almost 3 years ago

Staging Project openSUSE:Factory:Staging:B got accepted.

Places

Overview