Request 899041 (accepted)

This request supersedes: request 894926 (Show diff)

Overview

Request 899041 accepted

No description set

Created by dmdiss almost 3 years ago
In state accepted
Supersedes 894926

Submit leveldb

Comments for request 899041 0
Comments for request 894926 6

Dominique Leuenberger (dimstar) - almost 3 years ago

reviewer

Fails the build in ceph now:

[ 1547s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: ../../lib/libkv.a(LevelDBStore.cc.o):(.data.rel.ro._ZTI17CephLevelDBLogger[_ZTI17CephLevelDBLogger]+0x10): undefined reference to `typeinfo for leveldb::Logger'

Jan Engelhardt (jengelh) - almost 3 years ago

reviewer source maintainer

Well well well. Someone had the audacity to add -fno-rtti -fno-exceptions and produce some really non-standard C++. Of course ceph (which, for all intents and purposes, uses C++ in standards-conforming mode) can't use it.

Ferdinand Thiessen (susnux) - almost 3 years ago

Upstream thread for -fno-rtti: https://github.com/google/leveldb/issues/731

They suggest to either enable -fno-rtti for other libs as well (ceph in the case) or to patch it out. Building ceph with -fno-rtti is not a good idea, and it even does not work as ceph uses typeid. Probably removing -fno-rtti should not do any harm, as it should only increase the resulting file size.

At least when tested it, both testsuites (ceph and leveldb) succeeded with a patched leveldb.

Ferdinand Thiessen (susnux) - almost 3 years ago

The patched version I spoke of is this one: SR#898809