Note that using sort as a return value of a function can be harmful. sort in scalar context is undefined, so if you have a sub like this:

    sub foo {
        return sort [@x](https://build.opensuse.org/users/x);
    }
    my $num = foo();

and call it in scalar context, you will get back undef and not the number of elements. In the case of this patch I don't know if the function find_file is called in scalar context anywhere, I just wanted to note that one should avoid doing a sort on return directly and rather do something like:

    [@x](https://build.opensuse.org/users/x) = sort [@x](https://build.opensuse.org/users/x);
    return [@x](https://build.opensuse.org/users/x);

I don't know how to prevent "at-sign letter" being interpreted as a link to a user, sorry.

Tina Müller (tinita) - about 3 years ago

source maintainer

I extended the patch to enforce list context: https://build.opensuse.org/request/show/886980

@computersalat, @coolo, @dstoecker, @lrupp, @rjschwei, @smithfarm, @tinita: review reminder