Overview
Request 879887 accepted
- Update to 3.4.0:
- Remove rules C407 (Unnecessary comprehension
- can take a generator) and C412 (Unnecessary
comprehension - 'in' can take a generator).
Both rules recommended increasing laziness, which is not
always desirable and can lead to subtle bugs. Also, a fully
exhausted generator is slower than an equivalent
comprehension, so the advice did not always improve
performance.
- Drop Python 3.5 support.
- Support Python 3.9.
- Move license from ISC to MIT License.
- Partially reverted the change to C408 to make it apply again
to when dict is called with keyword arguments, e.g. dict(a=1,
b=2) will be flagged to be rewritten in the literal form
{"a": 1, "b": 2}
- Skip test test_C416_fail_1_list
(gh#adamchainz/flake8-comprehensions#313).
Request History
mcepl created request
- Update to 3.4.0:
- Remove rules C407 (Unnecessary comprehension
- can take a generator) and C412 (Unnecessary
comprehension - 'in' can take a generator).
Both rules recommended increasing laziness, which is not
always desirable and can lead to subtle bugs. Also, a fully
exhausted generator is slower than an equivalent
comprehension, so the advice did not always improve
performance.
- Drop Python 3.5 support.
- Support Python 3.9.
- Move license from ISC to MIT License.
- Partially reverted the change to C408 to make it apply again
to when dict is called with keyword arguments, e.g. dict(a=1,
b=2) will be flagged to be rewritten in the literal form
{"a": 1, "b": 2}
- Skip test test_C416_fail_1_list
(gh#adamchainz/flake8-comprehensions#313).
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added openSUSE:Factory:Staging:adi:68 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:68"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:68"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:68 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:68 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:68 got accepted.