Overview
Request History
pgajdos created request
Enable SSE optimizations. They are not enabled by default in configure-based builds (see the INSTALL file). (forwarded request 878383 from llunak)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
namtrac declined review
SSE doesn't exist on i586, you have to a
%configure \
--disable-static \
%ifarch x86_64
--enable-hardware-optimizations=yes \
%endif
%{nil}
namtrac declined request
SSE doesn't exist on i586, you have to a
%configure \
--disable-static \
%ifarch x86_64
--enable-hardware-optimizations=yes \
%endif
%{nil}
pgajdos revoked request
thanks
pgajdos reopened request
reopening
namtrac accepted review
ok
dimstar_suse set openSUSE:Factory:Staging:D as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:D"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:D"
RBrownSUSE accepted review
Staging Project openSUSE:Factory:Staging:D got accepted.
RBrownSUSE approved review
Staging Project openSUSE:Factory:Staging:D got accepted.
RBrownSUSE accepted request
Staging Project openSUSE:Factory:Staging:D got accepted.
So why does the package build on i586 just fine and even passes the test suite?
Because the code is more intelligent than me.
The code already checks for hardware support:
# ifdef PNG_INTEL_SSE /* Only check for SSE if the build configuration has been modified to * enable SSE optimizations. This means that these optimizations will * be off by default. See contrib/intel for more details. */ # if defined(__SSE4_1__) || defined(__AVX__) || defined(__SSSE3__) || \ defined(__SSE2__) || defined(_M_X64) || defined(_M_AMD64) || \ (defined(_M_IX86_FP) && _M_IX86_FP >= 2) # define PNG_INTEL_SSE_OPT 1 # else # define PNG_INTEL_SSE_OPT 0 # endif # else # define PNG_INTEL_SSE_OPT 0 # endif #endifYes, already checking that. In configure there is:
;; i?86|x86_64) enable_intel_sse=yes$as_echo "#define PNG_INTEL_SSE_OPT 1" >>confdefs.h
plus the above what coolo pasted imho means, that it can be enabled everywhere.