Who is "you"? I.e. whom do you ask? I cannot test it because I do not have such a printer. All I did was to verify that the new tar.gz is the original one and I had a look at bug_x86_64.patch and the source files it changes if the patch may introduce evil things but I cannot make decisions if what it changes is the right thing to make things work because I neither use that driver nor do I know anything about its code internals. As always I accepted it only for the "Printing" project so that users of our devel project could test it early before it gets automatically forwarded to Factory and all Tumbleweed users get it. As in the past I assume Antoine Belvire (who does those version upgrades since a longer time) did things right and had tested that it at least still works on his printer.

Martin Wilck (mwilck) - over 3 years ago

target maintainer

The question was meant for Antoine, as he'd created the request. I missed the fact that you'd accepted it already. Sorry.

What do you mean with "It seems to simply rip out the fifo code"? Did you perhaps misunderstand what "osc rdiff -c 51 Printing epson-inkjet-printer-escpr" shows about the changes in bug_x86_64.patch? That change removes one hunk in bug_x86_64.patch that - as far I see from looking at the source code - does no longer make sense to apply because that "XFIFOWrite" line is now commented in the new sources.

Martin Wilck (mwilck) - over 3 years ago

target maintainer

I saw that commented-out code, and that's what I called "gruesome".