Overview

Request 854906 accepted

- Replace %__python3 usage by %python_exec.
- Enable parallel hdf5:
* Implement multibuild for different flavors of openmpi.
* Export env variables `HDF5_LIBDIR` and `HDF5_INCLUDEDIR`
pointing to the hdf library and headers location when enabling
openmpi flavored builds.
* Add BuildRequires: python-pytest-mpi for mpi tests.
* Replace python rpm macros with their expansions in most cases
to adapt to mpi paths.

Loading...


Ismail Dönmez's avatar

@mcepl Please don't use double underscore variables in new code, such as: %__python3


Atri Bhattacharya's avatar

We should probably change that to %python_exec. However, https://github.com/openSUSE/python-rpm-macros says %__<flavor> is known and supported without cautioning against deprecation.


Ismail Dönmez's avatar

Yes, it's supported in other places too like %__make but these are from the BSD support stuff afair and is not really needed.


Matej Cepl's avatar
author source maintainer

Yes, %python_exec is always preferable.

I haven’t written %__python3 myself, I was just foolish enough to approve the submit request with it.


Atri Bhattacharya's avatar

@mcepl Aww, don't feel bad about yourself. Happens to the best of us 😁

Request History
Markéta Machová's avatar

mcalabkova created request

- Replace %__python3 usage by %python_exec.
- Enable parallel hdf5:
* Implement multibuild for different flavors of openmpi.
* Export env variables `HDF5_LIBDIR` and `HDF5_INCLUDEDIR`
pointing to the hdf library and headers location when enabling
openmpi flavored builds.
* Add BuildRequires: python-pytest-mpi for mpi tests.
* Replace python rpm macros with their expansions in most cases
to adapt to mpi paths.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:adi:18 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:18"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:18"


Ismail Dönmez's avatar

namtrac accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:18 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:18 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:18 got accepted.

openSUSE Build Service is sponsored by