Overview
Request 853478 accepted
New package. For further info see intro on mailing list: https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/message/WRLYKOC5KD247LWKNJ7GPPMFPW3HKRYR/
Switched to tar_scm to pass auto review.
- Created by nopeinomicon
- In state accepted
- Supersedes 853477
Request History
nopeinomicon created request
New package. For further info see intro on mailing list: https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/message/WRLYKOC5KD247LWKNJ7GPPMFPW3HKRYR/
Switched to tar_scm to pass auto review.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:22"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:22"
namtrac accepted review
This ok as is, rest can come as fixes on top.
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:22 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:22 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:22 got accepted.
@nopeinomicon
instead of this, you should do
Also obs_scm is actually preferred over tar_scm (including Factory) but I don't know the exact problem you had with it.
@namtrac
Ah, that first bit is definitely useful. Thanks for the advice! I'll implement it tomorrow morning since I need to sleep soon.
Also I reverted it because the factory-auto bot was complaining about not being able to find the .tar.gz archive specified in the .spec file. Is there any good workaround for that?
Here is what I do for dolphin: https://build.opensuse.org/package/view_file/Emulators/dolphin-emu/_service?expand=1 Note the mode="disabled", with that setup I run
And it runs all the disabled services, producing the obscpio file, that the bot is looking for.
Yeah, that's approximately what I had it at before, but the package would not build unless I renamed the tarball, and renaming it during obs_scm broke some of the services. That's why I had to use the clunky workaround renaming it in the tar service, but that breaks the bot.
Your old _service missed
That's why it's working now. There was a filename mismatch before.
Yeah, the old one was missing that, but for some reason the tar service failed to find the archive if I changed the filename param for obs_scm, but since tar_scm already packages into a tar, I didn't need that service, and thus didn't run into the problem. Not sure if that's some kind of bug or what, but that's why I wrote the file the way I did.