Since when have running tests become a requirement?
It has always been recommended. If possible, tests should be run where they are shipped, unless there is a missing pkg that is needed by the tests or the tests are broken as shipped by upstream. Tests ensure that the build works; I can't understand why this is a problem.
If you would have just said that these tests don't run for x.y.z reason, that would have been great. Instead you choose to confront my suggestions, made in good faith, with 'since when have tests been required', etc.
Look, your pkg, your project, feel free to check in whatever. I was just giving suggestions potentially to help, but they weren't in any way binding.
StefanBruens
@Dmitry_R, @Mailaender, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @cjunghans, @dstoecker, @eeich, @kwk, @mslacken, @openfoam, @psmt: review reminder
Thanks for the sr. Here are my suggestions:
python-bCNCas it installs a python module.%checksection.%suse_update_desktop_file.Source1.Its implemented in python, that does not make it a python module - firewall-applet, hplip are all implemented in python as well.
There are no tests run.
No full URL, as this uses a git snaphot/_service.
Its implemented in python, that does not make it a python module - firewall-applet, hplip are all implemented in python as well.
Yes, makes sense.
There are no tests run.
There is a tests directory. Don't tests in there work?
No full URL, as this uses a git snaphot/_service.
For
SOURCE1, the svg file?Since when have running tests become a requirement?
The svg file is a vectorized version of the included icon, it has no repository.
Since when have running tests become a requirement?
It has always been recommended. If possible, tests should be run where they are shipped, unless there is a missing pkg that is needed by the tests or the tests are broken as shipped by upstream. Tests ensure that the build works; I can't understand why this is a problem.
So, tell me, how should these tests be run?
Feel free to enhance the package.
If you would have just said that these tests don't run for x.y.z reason, that would have been great. Instead you choose to confront my suggestions, made in good faith, with 'since when have tests been required', etc.
Look, your pkg, your project, feel free to check in whatever. I was just giving suggestions potentially to help, but they weren't in any way binding.
Done with this, cheers.