Overview
Request 844816 accepted
update for multiple python3 flavors. See https://github.com/openSUSE/zypp-plugin/pull/3
- Created by bnavigator
- In state accepted
Request History
bnavigator created request
update for multiple python3 flavors. See https://github.com/openSUSE/zypp-plugin/pull/3
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse set openSUSE:Factory:Staging:I as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:I"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:I"
dimstar accepted review
mlandres accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:I got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:I got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:I got accepted.
42+%if %{singlespec_py3}
This will fail in case singlespec_py3 is not defined
That's why it is defined unconditionally in line 19. Has been for years, because it is used further up and further down. I did not change it.
Ah right - I only looked at the diff, not the entire spec file... that's how I missed it
Thanks for your feedback
@mlandres, @zbenjamin, @zypp-team: review reminder