Overview
Request 836091 accepted
OK
- Created by WernerFink
- In state accepted
- Supersedes 836059
31+mkdir -p %{buildroot}%{_prefix}%{_sysconfdir}/pam.d 32+cat > %{buildroot}%{_prefix}%{_sysconfdir}/pam.d/physlock <<-'EOF'
That took me two seconds to understand why this looks so weird :)
you likely want to use distconfdir here.
On old systems, you have this defined to be /etc, on newer systems it is pre-defined to be /usr/etc.
The way you package it now, it has potential to fail when distconfdir is not defined, as then you create the files in prefix/sysconfdir (aka /usr/etc) but in the files section you then use distconfdir, which has been redefined to sysconfdir, aka /etc
Request History
WernerFink created request
OK
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
RBrownSUSE added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:109"
RBrownSUSE accepted review
Picked "openSUSE:Factory:Staging:adi:109"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:109 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:109 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:109 got accepted.