This request supersedes:
request 834595
(Show diff)
Overview
Request 834826 accepted
- Pin Golang version to 1.14
- Add requires for fillup, groupadd, useradd, systemd (bsc#1175946)
- Created by witekbedyk
- In state accepted
- Package maintainers: STorresi and witekbedyk
- Supersedes 834595
Loading...
LGTM, osc rdiff home:witekbedyk:branches:server:monitoring golang-github-QubitProducts-exporter_exporter systemsmanagement:Uyuni:Master:openSUSE_Leap_15-Uyuni-Client-Tools
shows no differences.
Login required, please
login
in order to comment
Request History
witekbedyk created request
- Pin Golang version to 1.14
- Add requires for fillup, groupadd, useradd, systemd (bsc#1175946)
jcavalheiro accepted request
Pinning Go version to avoid resolution errors of type: have choice for golang(API) >= 1.14: go1.14 go1.15
https://build.suse.de/package/show/Devel:Galaxy:Manager:Head:SLE12-SUSE-Manager-Tools/golang-github-QubitProducts-exporter_exporter
Maybe instead of using a stricter requirement in the package spec, consider adding a Prefer: go1.14 statement to the OBS project config, so that the package will not need any update, more so because this is only a limitation of some specific repositories.
Here is an example: https://build.opensuse.org/projects/home:STorresi:containers/prjconf.
I would also suggest to use the
%systemd_ordering
macro instead of%systemd_requires
, which is more relaxed and will allow for easier containerization in the future.Cheers!
The first part of the request is actually a backport of the bugfix (bsc#1175946) which has landed already in SUSE:SLE-15:Update project. The contributor wasn't aware of server:monitoring and provided the fix on SUMA development project only. Taking this into account I'd suggest to accept the backport in the current shape and I will change to %system_ordering in the follow-up request.
In regard of Go version pinning, I also thought about configuring the project, but product maintenance engineers are reluctant to do that. Again, the goal is to include it in SUSE:SLE-15:Update.
I have triggered a discussion about Go versions resolution in #go channel on Rocket.Chat. Improvements in Go metapackage are considered. Until the solution gets implemented I think we can live with the proposed workaround.
@AndreasStieger, @STorresi, @aeneas_jaissle, @aldemir_a, @bitshuffler, @bnicholes, @ciriarte, @dakechi, @darix, @deadpoint, @dmaiocchi, @dstoecker, @jfajerski, @lrupp, @marostegui, @mcaj, @mge1512, @mnhauke, @mseben, @netmask, @peternixon, @psmt, @rhomann, @schubi2, @shapbot, @worldcitizen, @wrosenauer: review reminder