Request 834311 (accepted)

This request supersedes: request 834159 (Show diff)

Overview

Request 834311 accepted

- Add budgie-desktop-branding to Recommends
- Add patch Revert-GNOME-3.38-support.patch: Leap 15.2 only
- Updated BuildRequires:
* pkgconfig(libmutter-6/7) >> pkgconfig(libmutter-5/6/7)

Created by gmbr3 over 3 years ago
In state accepted
Supersedes 834159

Submit budgie-desktop

Comments for request 834311 2

Dominique Leuenberger (dimstar) - over 3 years ago

reviewer

12+%define gnome_version %(rpm -q --queryformat='%%{VERSION}' libgnome-desktop-3-devel | sed 's/\.[0-9]*$//g')
51+%if "%{gnome_version}" < "3.36"
%patch3 -p1
%endif

Nothing wrong with this way of doing it, but I'd recommend, for future submission, to change this to something like:

if pkg-config --max-version 3.36 gnome-desktop-3.0; then
%patch3 -p1
fi

It's less fragile than trying to interpret version numbers out of rpm output.

Callum Farmer (gmbr3) - over 3 years ago

author source maintainer

@dimstar Thanks! I'll change it to that when I next have other changes.

Request History

gmbr3 created request over 3 years ago

- Add budgie-desktop-branding to Recommends
- Add patch Revert-GNOME-3.38-support.patch: Leap 15.2 only
- Updated BuildRequires:
* pkgconfig(libmutter-6/7) >> pkgconfig(libmutter-5/6/7)