Overview
Request 833929 accepted
Not needed anymore, fails to build with Qt 5.15.1
- Created by Vogtinator
- In state accepted
Request History
Vogtinator created request
Not needed anymore, fails to build with Qt 5.15.1
licensedigger accepted review
factory-auto accepted review
ok
RBrownSUSE set openSUSE:Factory:Staging:D as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:D"
RBrownSUSE accepted review
Picked "openSUSE:Factory:Staging:D"
favogt_factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
favogt_factory accepted review
Unstaged from project "openSUSE:Factory:Staging:D"
favogt_factory set openSUSE:Factory:Staging:F as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:F"
favogt_factory accepted review
Picked "openSUSE:Factory:Staging:F"
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:F got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:F got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:F got accepted.
Well, it is still "needed" for purpose (two plugins IIRC).
I would have a fix for the build failure, it's enough to remove the "-Werror" compiler option.
See SR#834223
That's odd, because if it was actually Required then repo-checker would not allow this delete request to proceed.
In that case, let's put it back.
It's not required, because it only affects two plugins.
Maybe we should add a Recommends though, or (probably better) split out those plugins and make them require it.
PS: I already asked about this topic in several SR's, but nobody cared to reply...
I checked, purpose doesn't require it and nothing else pulls it in. So effectively those plugins never actually worked unless someone installed accounts-qml-module manually, which is unlikely...
It would be possible to reintroduce it quickly before openSUSE:Factory finishes building, but I don't think we need to hurry due to ^.
It was required by kaccounts-providers until recently.
Sorry, I mean kaccounts-integration, which is installed by default.
Yes, but now it's not pulled in by anything: https://github.com/bmwiedemann/openSUSE/search?q=accounts-qml-module&unscoped_q=accounts-qml-module
I asked to get the accounts-qml-module sr added into the next snapshot, that way there's no weakremover.
Does purpose have proper support for only listing modules which can be loaded or do we need a Requires: accounts-qml-module, possibly in a new subpackage with just those modules?
The plugins are written in QML, so we would need to add the dependency manually.
The plugins do show up without the dependencies being installed, they just won't work (i.e. they just show an empty window) .
As already posted elsewhere:
grep Ubuntu /usr/share/purpose/*
/usr/share/purpose/nextcloudplugin_config.qml:import Ubuntu.OnlineAccounts 0.1 as OA
/usr/share/purpose/youtubeplugin_config.qml:import Ubuntu.OnlineAccounts 0.1 as OA
At least the nextcloud plugin was overhauled upstream recently so it should work, I'm not sure about youtube.
Ok, sr 834295
@Vogtinator: As this has been accepted despite my concern, you should also remove the corresponding plugins from purpose then IMHO.
I won't do it, as I tried to provide a fix anyway.