Overview
Request 830843 accepted
No description set
- Created by mcalabkova
- In state accepted
Loading...
Request History
mcalabkova created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar accepted review
dimstar_suse set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:H"
licensedigger accepted review
ok
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:H got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:H got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:H got accepted.
Good job, wouldn’t those be good patches to send upstream? Sane upstream maintainer may be only happy with extending compatibility with older pytests (plus you get code review for free).
I don't think so... did you read my comment in spec?
Yeah, I did, but sometime when the upstream learns that what they want could be done cheaply and without breaking backwards compatibility, they may go for it.
However, I wanted mostly to stop and make you think about it. You obviously did and decided that I have no clue what I am talking about (which is most true).
Go ahead with this.