Overview
Request 827700 accepted
- Update to 5.4.2:
* Fixed #1383: Known other does not work anymore with .editorconfig.
* Fixed: Regression in first known party path expansion.
* Fixed #1381: --combine-as loses # noqa in different circumstances.
* Implemented #1373: support for length sort only of direct (AKA
straight) imports.
* Fixed #1321: --combine-as loses # noqa.
* Fixed #1375: --dont-order-by-type CLI broken.
Request History
StevenK created request
- Update to 5.4.2:
* Fixed #1383: Known other does not work anymore with .editorconfig.
* Fixed: Regression in first known party path expansion.
* Fixed #1381: --combine-as loses # noqa in different circumstances.
* Implemented #1373: support for length sort only of direct (AKA
straight) imports.
* Fixed #1321: --combine-as loses # noqa.
* Fixed #1375: --dont-order-by-type CLI broken.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:H as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:H"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:H"
licensedigger accepted review
ok
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:H got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:H got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:H got accepted.
Just noting that "test_hypothesmith because no libcst because no pyre-check" in the spec is no longer strictly correct - I got python-libcst into d-l-py, but it is possibly not fully working as pyre-check isnt packaged yet (and is a huge headache to package, so dont bother unless you have a huge chunk of spare time).
That one is still unresolvable in d:l:p. You also need to submit your typing-inspect.
Even with that, I am still unsure if we can use it without pyre.
thanks for the heads up. typing-inspect was in my py-submit project ready to roll. https://build.opensuse.org/request/show/827911
I do use it without pyre - it does work. you can confirm that with django-codemod, and likely quite a few other tools which use libcst for the raw cst, rather than for linting/formatting type analysis which is what pyre will be adding. isort may fall into that latter bucket - not sure.