Overview

Request 827286 accepted

- Add resolve_depreciations.patch to clean deprecation warnings
(gh#python-social-auth/social-core#500)


Tomáš Chvátal's avatar

Wouldn't it be easier then to bump to 3.4.0 that does not need the conversion? The convertor really makes sesnse for dead projects, but otherwise it might make more sense just to pick the commits or convince upstream to release a new version.


John Vandenberg's avatar

Because it isnt released yet https://github.com/python-social-auth/social-core/issues/485 And I havent reviewed the changes yet, but a minor release of social-auth-core needs to be regression tested against its dependencies because its dependencies often break on minor updates.

And when this package is updated, almost certainly this .spec will keep working as-is, and ideally the pytest plugin will warn when it is no longer needed (it already knows this, but doesnt report it in exit status or pytest warnings), or someone will notice and remove it from the spec. Normal maintenance activities.


Tomáš Chvátal's avatar

The problem is the crust tend to stay, I can guarantee you that if you put something in the pkg it stays there for quite time before someone notices it is not really useful anymore. Here as it is in upstream I would just suggest adding comment explaining something along the lines "remove after updating to release x.y.z' and hope it would be enough to make people to notice.


John Vandenberg's avatar

You are not telling me something I do not know. However cleaning up old crap in spec files is normal. I also help doing it, as you well know. So why block my potential future crust, when you do not block all the other crust that ends up in the spec files.

And moreover, this specific crust will not stay when the tool errors when it doesn't do any conversion. How about we build that instead?

Request History
Matej Cepl's avatar

mcepl created request

- Add resolve_depreciations.patch to clean deprecation warnings
(gh#python-social-auth/social-core#500)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:83"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:83"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:83 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:83 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:83 got accepted.

openSUSE Build Service is sponsored by