Overview
Request 822251 accepted
- Remove -m32 and -m64 options except for x86* and ppc*
- Created by Guillaume_G
- In state accepted
Request History
Guillaume_G created request
- Remove -m32 and -m64 options except for x86* and ppc*
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added openSUSE:Factory:Staging:adi:44 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:44"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:44"
davidnichols accepted review
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:44 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:44 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:44 got accepted.
Your change will impact all other arches, for example s390x, is it expected ? What is original failure ? only arm specific ?
My goal was to fix build on all archs which do not support -m32 and -m64 flags, including aarch64 and %{arm}, but more archs are probably affected (riscv?).
s390 seems to support -m31 and -m64.
Please note that this patch is more than 2 years old but is just a resubmission. ;)
I don't know about s390x, but these flags (-m32 & -m64) cause breakage on other arches (like linux for arm* for example), and these changes have already been applied in the upstream sources for this and other qore packages, so least for arm* they are correct, and because they were only implemented for x86 and ppc originally, the patch makes sense to me from that point of view.