Overview
Request 82020 superseded
update
- Created by mlandres
- In state superseded
- Superseded by 94300
-
Open review for
legal-team
Request History
mlandres created request
update
licensedigger added a reviewer
{"delegate": "license change"}
coolo added a reviewer
Please review sources
saschpe declined request
Time to cleanup, please remove the stuff under %changelog (i.e. move to changes file), use %make_install instead of 'make install DESTDIR...'. You don't need AutoReqProv and Prefix in the preamble anymore. Feel free to remove authors from description, it's not done for quite some time anymore. And consider running spec-cleaner. There should be no need to add --prefix, --mandir & co to %configure, it's already contained (use rpm --eval %configure to check). Instead of make %{jobs...}, you can use make %{?_smp_flags}.
supersede declined request with a followup request
licensedigger accepted review
{"delegate": "license change"}
coolo accepted review
Builds for repo openSUSE_Factory
saschpe declined review
Time to cleanup, please remove the stuff under %changelog (i.e. move to changes file), use %make_install instead of 'make install DESTDIR...'. You don't need AutoReqProv and Prefix in the preamble anymore. Feel free to remove authors from description, it's not done for quite some time anymore. And consider running spec-cleaner. There should be no need to add --prefix, --mandir & co to %configure, it's already contained (use rpm --eval %configure to check). Instead of make %{jobs...}, you can use make %{?_smp_flags}.
