Request 817528 (superseded)

This request is superseded by request 817642 (Show diff)

Overview

Request 817528 superseded

No description set

Created by plater almost 4 years ago
In state superseded
Superseded by 817642
Open review for opensuse-review-team
Open review for factory-staging

Submit lame

Comments for request 817528 7

Ismail Dönmez (namtrac) - almost 4 years ago

@plater Instead of running echo many times, use a heredoc with cat instead: https://linuxize.com/post/bash-heredoc/#basic-heredoc-examples

Jan Engelhardt (jengelh) - almost 4 years ago

reviewer

But echo is practically a shell-builtin and cat isn't :-p

echo "Name: abc
Version: 0
Cflags: $blah" >x.pc

Ismail Dönmez (namtrac) - almost 4 years ago

Thanks! :)

Dave Plater (plater) - almost 4 years ago

author source maintainer

Would have made my life simpler, I could have just pasted the twolame pc file I used as a template without having to add the echo's. I have to resubmit for the libdir, I've seen heredocs but haven't understood them so I just stuck to echo.

Dominique Leuenberger (dimstar) - almost 4 years ago

reviewer

Libdir is being hardcoded to lib64

Dave Plater (plater) - almost 4 years ago

author source maintainer

woops I was supposed to use a macro, will fix it

Dave Plater (plater) - almost 4 years ago

author source maintainer

I made the same mistake with audacity

Request History

plater created request almost 4 years ago

factory-auto added opensuse-review-team as a reviewer almost 4 years ago

Please review sources

factory-auto accepted review almost 4 years ago

Check script succeeded

licensedigger accepted review almost 4 years ago

dimstar_suse set openSUSE:Factory:Staging:E as a staging project almost 4 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:E"

dimstar_suse accepted review almost 4 years ago

Picked "openSUSE:Factory:Staging:E"

dimstar declined review almost 4 years ago

Declining based on all the comments

dimstar declined request almost 4 years ago

Declining based on all the comments

dimstar_suse reopened request almost 4 years ago

Reopened via staging workflow.

dimstar_suse added factory-staging as a reviewer almost 4 years ago

Being evaluated by group "factory-staging"

dimstar_suse accepted review almost 4 years ago

Unstaged from project "openSUSE:Factory:Staging:E"

dimstar_suse declined request almost 4 years ago

Declined via staging workflow.

plater superseded request almost 4 years ago

Places

Overview