Overview
Request 813237 accepted
- Ensure ARM arch is set properly - boo#1169832
- Created by Guillaume_G
- In state accepted
- Supersedes 812465
Thanks for this SR series, Guillaume. I will definitely accept the change to ensure ARM arch is set properly, and have accepted for go1.4, go1.9, go1.14. Can you submit a superseding SR series for go1.10, go1.11, go1.12, go1.13 with just that change in isolation? We can get that change out immediately.
For go1.10, go1.11, go1.12, go1.13 there are additional moves of rpm .spec blocks that should be considered separately. Those changes look good, but will require some additional time to review and test and shouldn't hold up the ARM arch change. I appreciate that you've applied them to multiple versions consistently, thanks.
Itemized rationale for block moves, why one set of statements should be before the other, etc., should be included in the changelog so reviewers can follow the logic for the new groupings. More readable is a perfectly good reason, the go1.x .spec is indeed getting complicated. Smaller SRs to reorganize in steps might work best to get these changes into openSUSE and SLE.
One additional note: use of the %license macro needs to be conditional on suse_version:
%if 0%{?suse_version} < 1500 %doc LICENSE %else %license LICENSE %endif%
Request History
Guillaume_G created request
- Ensure ARM arch is set properly - boo#1169832
jfkw accepted review
Review OK for devel:languages:go
jfkw approved review
Review OK for devel:languages:go
jfkw accepted request
Accept to devel:languages:go