130+if [ -d /run/uscreens/S-cscreen ];then
131+    if [ "$1" == "0" ];then
132+        # Only delete on uninstall
133+        rm -rf /run/uscreens/S-cscreen
134+    else
135+        # Adjust to possible new user on upgrade
136+        chmod -R %{USERNAME}:%{GROUPNAME} /run/uscreens/S-cscreen
137+    fi
138+fi

TRAP!

we aware that the postun scrip run is the script of the package that is just being uninstalled - so in case of a package upgrade (let;s say from version 1.0 to 2.0) you get the %post script of pkg version 2.0, but the postun of version 1.0 -if 2.0 would ever use a different USERNAME/GROUPNAME (which is presumably the only reason why chowning on uninstall?!) then you own all files to the OLD username used in version 1,0 - not what 2.0 defined

additional comment:

131+ if [ "$1" == "0" ];then

post/postunscriptlets are run using /bin/sh - i.e. posix compliant shell. but if [ "$1" == "0" ]; is bashism. posix only uses a sinlge = (see man test)

21+Requires(postun): coreutils

This we also are in process of eliminating as good as possible (think busybox here)

Can you please use Requires(postun): /usr/bin/rm /usr/bin/chmod here?

Thomas Renninger (trenn) - almost 4 years ago

author source maintainer

Thanks a lot for the detailed review! I'll resubmit.