Overview

Request 812206 superseded

New package copied from Fedora to replace the now obsolete libopenmpt provided package.

Loading...

Jan Engelhardt's avatar

Why not https://lib.openmpt.org/libopenmpt/2020/04/14/release-libopenmpt-modplug-0.8.9.0-openmpt1/ ?


Dave Plater's avatar
author source maintainer

That produces libopenmpt_modplug not libmodplug. All the other distributions have libmodplug, I can vaguely remember it in openSUSE as well, was most probably deleted in favor of the one provided by libopenmpt.


Jan Engelhardt's avatar

I have checked the ABIs.

First, libmodplug-0.9.8's libmodplug.so.1 against libopenmpt-0.4.12's libmodplug.so.1:

» abidiff $a/libmodplug.so.1 $b/libmodplug.so.1
[...]
3 Removed function symbols not referenced by debug info:

  _ZN10CSoundFile13InitializeDSPEb
  _ZN10CSoundFile14ProcessMonoDSPEi
  _ZN10CSoundFile16ProcessStereoDSPEi

Well that's a great start :-/ so libopenmpt was binary incompatible all along. But no one noticed, so openmpt has that going for it.

Now, libopenmpt-0.4.12's libmodplug.so.1 against libopenmpt-modplug-0.8.9.0's libopenmpt_modplug.so.1:

» abidiff $b/libmodplug.so.1 $c/libopenmpt_modplug.so.1
ELF SONAME changed
Functions changes summary: 0 Removed, 0 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

SONAME changed from 'libmodplug.so.1' to 'libopenmpt_modplug.so.1'

So no ABI change there. This suggests that if libopenmpt-modplug was built with the right SONAME, we would have the same situation as a few days ago. Sounds like a plan?


Dave Plater's avatar
author source maintainer

I was looking for a quick clean solution I also dislike long names, somebody else is welcome to create libopenmpt_modplug1 and provide libmodplug1 Have a look at the git fork https://github.com/Konstanty/libmodplug, it is a currently active fork of the original libmodplug


Dave Plater's avatar
author source maintainer

The libopenmpt_modplug also has this option: --enable-libmodplug Enable libmodplug replacement library based on libopenmpt. WARNING: This will replace your current libmodplug installation. CAUTION: The emulation of the libmodplug interface is not complete as libmodplug exposes lots of internal implementation details. If any of those is used by an application, the emulation via libopenmpt will fail and/or crash.


Dave Plater's avatar
author source maintainer

I was stupid not to search for libmodplug in openSUSE it's last days were in Leap:42.3:Update using the github version. modplug is very old and it's only use is for converting music that was made in the 90s but it's nice to have it around. It still builds with gcc10


Jan Engelhardt's avatar

Well even for 90s music, one can use openmpt or xmp or something :-)

Request History
Dave Plater's avatar

plater created request

New package copied from Fedora to replace the now obsolete libopenmpt provided package.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:104"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:104"


openSUSE Build Service is sponsored by