Overview

Request 812191 accepted

Dependency of https://build.opensuse.org/request/show/812187


Tomáš Chvátal's avatar

Could the tests be executed by something else than nose? https://trello.com/c/K55RdSDw/42-remove-nose


John Vandenberg's avatar

Probably; i'll try.


John Vandenberg's avatar

Not easily

[   64s] py_vapid/tests/test_vapid.py:8: in <module>
[   64s]     from nose.tools import eq_, ok_
[   64s] E   ModuleNotFoundError: No module named 'nose'

Tomáš Chvátal's avatar

Bad, we usually had to open new PRs. Issue is that even if I accept this now it will break in few months as nose will stop working :) Otoh replacing eq_ and ok_ should be quite straight forward.


John Vandenberg's avatar

Sorry which exact problem is going to cause nose to break? https://github.com/nose-devs/nose/issues/1099 suggests it isnt broken in 3.9


Tomáš Chvátal's avatar

Seems like the major removals were postproned to 3.10 in the end, so we have year extra.


John Vandenberg's avatar

I've raised https://github.com/web-push-libs/vapid/issues/86 to get the ball rolling for all of these web-push repos , which are actively maintained. We can expect many releases between now and Python 3.10.


Tomáš Chvátal's avatar

So we can keep these on nose for now, just please replace the %python3_only with %python_alternative and this is acceptable.


John Vandenberg's avatar

great. will do later today


John Vandenberg's avatar

Done


Request History
John Vandenberg's avatar

jayvdb created request

Dependency of https://build.opensuse.org/request/show/812187


Tomáš Chvátal's avatar

scarabeus_iv accepted request

openSUSE Build Service is sponsored by