Overview

Request 774215 accepted

- fix-locking-in-_IO_cleanup.patch: update to latest version (forwarded request 774214 from Andreas_Schwab)

Loading...

Dominique Leuenberger's avatar
20+  * The obsolete function stime is no longer available to newly linked
21+    binaries, and its declaration has been removed from <time.h>

That breaks at least busybox: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:B/busybox/standard/x86_64

@ihno and @kukuk


Dominique Leuenberger's avatar

breaks chrony:

[   65s] client.c:566:5: error: conflicting types for 'gettimeofday'
[   65s]   566 | int gettimeofday(struct timeval *tv, struct timezone *tz) {

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:B/chrony/standard/x86_64

CC @rmax


Dominique Leuenberger's avatar

BReaks datefudge:

[   16s] datefudge.c:81:5: error: conflicting types for 'gettimeofday'
[   16s]    81 | int gettimeofday(struct timeval *x, struct timezone *y) {

CC @namtrac (you originally packaged it) @AndreasStieger (you updated it once) and @adamm (you submitted the update to the devel prj)

I guess the rest of the people listed as maintainers (prj maintainers of devel:libraries:c_c++ care even less than you folks)



Dominique Leuenberger's avatar

LLVM9 failure COULD be related here:

[ 3593s] /home/abuild/rpmbuild/BUILD/llvm-9.0.1.src/stage1/bin/clang++  -DHAVE_RPC_XDR_H=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/sanitizer_common -I../projects/compiler-rt/lib/sanitizer_common -I/usr/include/libxml2 -Iinclude -I../include -I../projects/compiler-rt/lib/sanitizer_common/.. -O2 -Wall -D_FORTIFY_SOURCE=0 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -fPIC -fvisibility-inlines-hidden -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -flto=thin -Wall -std=c++11 -Wno-unused-parameter -O2 -g -DNDEBUG    -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtual-dtor -fno-rtti -Wframe-larger-than=570 -Wglobal-constructors -MD -MT projects/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_posix.cc.o -MF projects/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_posix.cc.o.d -o projects/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_posix.cc.o -c ../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc
[ 3593s] ../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:1131:1: error: 'assertion_failed__1131' declared as an array with a negative size
[ 3593s] CHECK_SIZE_AND_OFFSET(ipc_perm, mode);
[ 3593s] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 3593s] ../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h:1437:3: note: expanded from macro 'CHECK_SIZE_AND_OFFSET'
[ 3593s]   COMPILER_CHECK(sizeof(((__sanitizer_##CLASS *) NULL)->MEMBER) == \
[ 3593s]   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 3593s] ../projects/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:336:30: note: expanded from macro 'COMPILER_CHECK'
[ 3593s] #define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
[ 3593s]                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 3593s] ../projects/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:342:57: note: expanded from macro 'IMPL_COMPILER_ASSERT'
[ 3593s]     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
[ 3593s]                                                         ^~~~~~~~~~~~~~~
[ 3593s] 1 error generated.
```CC maintainers [@aaronpuchert](https://build.opensuse.org/users/aaronpuchert) and [@ptesarik](https://build.opensuse.org/users/ptesarik)


Aaron Puchert's avatar

@Andreas_Schwab pushed a fix for that, is in sr#769880, currently staged in F.


Dominique Leuenberger's avatar

Thanks! I missed that one - moved to :B

Request History
Andreas Schwab's avatar

Andreas_Schwab created request

- fix-locking-in-_IO_cleanup.patch: update to latest version (forwarded request 774214 from Andreas_Schwab)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:B as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:B"


Staging Bot's avatar

staging-bot accepted review

Picked "openSUSE:Factory:Staging:B"


Ismail Dönmez's avatar

namtrac accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:B got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:B got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:B got accepted.

openSUSE Build Service is sponsored by