Overview
Request 760501 accepted
No description set
- Created by cgiboudeaux
- In state accepted
Loading...
Request History
cgiboudeaux created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:29"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:29"
namtrac accepted review
licensedigger accepted review
ok
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:29 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:29 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:29 got accepted.
@cgiboudeaux there are two licensing issues:
Qt Commercial: 1 files kstars-3.3.9/kstars/kstarslite/skyitems/skynodes/material/dashedshader.h
Any perm noncommercial: 5 files kstars-3.3.9/README.images kstars-3.3.9/doc/faq.processed.docbook kstars-3.3.9/kstars/skyobjects/skyobject.processed.cpp kstars-3.3.9/kstars/main.processed.cpp kstars-3.3.9/po/en_GB/docs/kstars/faq.processed.docbook
Bassically the sa-nc licenses are not acceptable for inclusion. I guess the header has wrong license by accident tho.
dashedshader.h is dual licensed commercial or LGPL 2.1 or 3 + exception, so not an issue, main.cpp, skyobject.cpp are GPL-2.0-or-later
The docbook don't seem to carry a license header. What makes you think they're sa-nc ?
It is said in readme that some of the files are non-commercial and the scanner picks it up.
Sounds like a false positive. the NC images listed in README.images lists are available via the 'Get New Stuff' feature (ie: downloaded on demand by users)