Overview

Request 754660 accepted

- Update to 0.15.4
+ Add reboot_suggested field to UpdateRecord (rh#1772466)
+ Skip directory matching --exclude right away
+ Add restart_suggested to updatecollectionpackage

- Update to 0.15.3
+ Export all changelog entries in compatibility mode
+ Libmagic to follow symlinks (rh#1776399)
+ Add shortcut to detect *.yaml files as not compressed
- Ensure createrepo_c fully replaces createrepo on Tumbleweed
- Remove old and now unused dependency on deltarpm as drpm is used now

- Update to 0.15.2
+ Fix file mode for cache (rh#1686812)
+ Honor umask on cache files (rh#1686812)
- Enable DeltaRPM support for openSUSE targets on Leap 15.2+ and TW

- Add BuildRequires on python3, it won't be pulled in side effect of
requiring python3-nose

- fix build by adding missing tarball and updating filelist

- Update to version 0.15.1:
* Release 0.15.1
* Fix null pointer crash in cr_dumper_thread() if it fails to get checksum
* Fix search in string with missing terminating zero (rh#1750673)
* Depend on DRPM minimum version 0.4.0
* Release 0.15.0
* Revise drpm dependency check and bump the minimum version to 0.3.0
* Release 0.14.4
* Update documentation and regenerate man pages to sync up
* Use drpm_make from drpm instead of deltarpm (rh#1687843)
* Fix some DEBUG build warnings
* Switch off html timestamps on documentation (rh#1731050)
* Update documentation for mergerepo_c merge methods (rh#1722803)
* Update documentation for --retain-old-md and --compatibility
* Fix --read-pkgs-list to only list actually read packages
* Release 0.14.3
* Add missing python metadata to python2/3-createrepo_c (rh#1695677)
* detect plain tar file as non compressed

- Update to 0.14.2
+ Fix issue with createrepo_c hanging at the end (rh#1714666)
+ Don't include packages with forbidden control chars in repodata (boo#1110914)
+ Correct pkg count in headers if there were invalid pkgs (rh#1596211)
+ Prevent exiting with 0 if errors occur while finalizing repodata

- Update to 0.14.0
+ Fix crash when dumping updateinfo and module is omitted (rh#1707981)
+ Add --pkgorigins mode

- Update to 0.13.1
+ Fix tests to work properly when modulemd support is not enabled
- Enable modulemd support on openSUSE Leap 15.1+ and Tumbleweed

- Update to 0.13.0
+ Add support for handling modulemd
+ Add support for Koji simple merge mode
+ Add support for zchunked modulemd
+ Fixed --keep-all-metadata to keep all additional metadata
- Disable tests if modulemd support is not enabled to prevent wrong failures
- Drop patches included in this release
+ 0001-Find-correct-nosetests-version-even-when-which-comma.patch
+ 0002-fix-linking-when-Wl-no-undefined-is-set.patch

- Use noun phrase in summary.

- Added upstream patches
* 0001-Find-correct-nosetests-version-even-when-which-comma.patch
* 0002-fix-linking-when-Wl-no-undefined-is-set.patch
- Drop included patches
* 0001-zck_end_chunk-returns-number-of-bytes-written-or-1-f.patch
* 0002-Add-missing-sentinal.patch
* 0003-Fix-misc-test.patch
- Disable drpm support
- Update to version 0.12.1:
* Release 0.12.1
* For make test, xz and zchunk (not just *-devel) are required.
* Make cmake variable PYTHON_EXECUTABLE global
* Add zchunk support already to Fedora 29
* [spec] Fix spec to work for epel 7
* Add CMake support for python interpreter path
* Add space after if statement
* Fix misc test
* Add missing sentinal
* Add zchunk support to mergerepo_c for extra files

- [boo#1125044] fix for huge rpm packages

Loading...

Dominique Leuenberger's avatar

plenty of fun failures, like:

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:G/kubic-kube-apiserver-image/images/x86_64

[   48s] C_CREATEREPOLIB: Critical: Cannot dump XML for kubernetes-apiserver (ee3c7a74080b44ecd29733e21f73ab4e9ffdf3deae9fae038df4e6766ce3de9d): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).

so, yeah.. createrepo_c still does not gracefully handle garbage-in and will make for a really hard time.

Moving to the backlog


Dominique Leuenberger's avatar

Can't really move forward as long as it's so picky about changelogs


Frank Schreiner's avatar

From my POV we need a cleanup of the changelogs in Factory - other.xml will stay broken otherwise - lets have a look what breaks and fix it. BTW: I already made a PR for upstream rpmlint - is this in factory already?


Neal Gompa's avatar

@dimstar_suse and I realized earlier today that we have to fix the changelogs now, since RPM 4.15 refuses to build the packages with broken spec data (including changelogs).

Fortunately, the list of broken packages appears to be quite small:

$ find -maxdepth 3 -name "*.spec" -exec file {} \; | grep -v -e UTF-8 -e "ASCII text"
./p/perl-Text-Unidecode/perl-Text-Unidecode.spec: ISO-8859 text
./p/perl-Net-IDN-Nameprep/perl-Net-IDN-Nameprep.spec: ISO-8859 text
$ find -maxdepth 3 -name "*.changes" -exec file {} \; | grep -v -e UTF-8 -e "ASCII text"
./t/termcap/termcap.changes: ISO-8859 text
./w/wireless-tools/wireless-tools.changes: ISO-8859 text
./p/perl-Mail-IMAPClient/perl-Mail-IMAPClient.changes: ISO-8859 text
./p/perl-Test-CPAN-Meta/perl-Test-CPAN-Meta.changes: ISO-8859 text
./p/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS.changes: data
./b/biabam/biabam.changes: ISO-8859 text
./n/nasm/nasm.changes: data
./m/matrix-synapse/matrix-synapse-test.changes: empty
./k/kubernetes/kubernetes.changes: data
./k/kubernetes/kubectl.changes: data

Once these are fixed and merged into Factory, then RPM 4.15.1 and createrepo_c 0.15.3 will work.

Request History
Neal Gompa's avatar

Pharaoh_Atem created request

- Update to 0.15.4
+ Add reboot_suggested field to UpdateRecord (rh#1772466)
+ Skip directory matching --exclude right away
+ Add restart_suggested to updatecollectionpackage

- Update to 0.15.3
+ Export all changelog entries in compatibility mode
+ Libmagic to follow symlinks (rh#1776399)
+ Add shortcut to detect *.yaml files as not compressed
- Ensure createrepo_c fully replaces createrepo on Tumbleweed
- Remove old and now unused dependency on deltarpm as drpm is used now

- Update to 0.15.2
+ Fix file mode for cache (rh#1686812)
+ Honor umask on cache files (rh#1686812)
- Enable DeltaRPM support for openSUSE targets on Leap 15.2+ and TW

- Add BuildRequires on python3, it won't be pulled in side effect of
requiring python3-nose

- fix build by adding missing tarball and updating filelist

- Update to version 0.15.1:
* Release 0.15.1
* Fix null pointer crash in cr_dumper_thread() if it fails to get checksum
* Fix search in string with missing terminating zero (rh#1750673)
* Depend on DRPM minimum version 0.4.0
* Release 0.15.0
* Revise drpm dependency check and bump the minimum version to 0.3.0
* Release 0.14.4
* Update documentation and regenerate man pages to sync up
* Use drpm_make from drpm instead of deltarpm (rh#1687843)
* Fix some DEBUG build warnings
* Switch off html timestamps on documentation (rh#1731050)
* Update documentation for mergerepo_c merge methods (rh#1722803)
* Update documentation for --retain-old-md and --compatibility
* Fix --read-pkgs-list to only list actually read packages
* Release 0.14.3
* Add missing python metadata to python2/3-createrepo_c (rh#1695677)
* detect plain tar file as non compressed

- Update to 0.14.2
+ Fix issue with createrepo_c hanging at the end (rh#1714666)
+ Don't include packages with forbidden control chars in repodata (boo#1110914)
+ Correct pkg count in headers if there were invalid pkgs (rh#1596211)
+ Prevent exiting with 0 if errors occur while finalizing repodata

- Update to 0.14.0
+ Fix crash when dumping updateinfo and module is omitted (rh#1707981)
+ Add --pkgorigins mode

- Update to 0.13.1
+ Fix tests to work properly when modulemd support is not enabled
- Enable modulemd support on openSUSE Leap 15.1+ and Tumbleweed

- Update to 0.13.0
+ Add support for handling modulemd
+ Add support for Koji simple merge mode
+ Add support for zchunked modulemd
+ Fixed --keep-all-metadata to keep all additional metadata
- Disable tests if modulemd support is not enabled to prevent wrong failures
- Drop patches included in this release
+ 0001-Find-correct-nosetests-version-even-when-which-comma.patch
+ 0002-fix-linking-when-Wl-no-undefined-is-set.patch

- Use noun phrase in summary.

- Added upstream patches
* 0001-Find-correct-nosetests-version-even-when-which-comma.patch
* 0002-fix-linking-when-Wl-no-undefined-is-set.patch
- Drop included patches
* 0001-zck_end_chunk-returns-number-of-bytes-written-or-1-f.patch
* 0002-Add-missing-sentinal.patch
* 0003-Fix-misc-test.patch
- Disable drpm support
- Update to version 0.12.1:
* Release 0.12.1
* For make test, xz and zchunk (not just *-devel) are required.
* Make cmake variable PYTHON_EXECUTABLE global
* Add zchunk support already to Fedora 29
* [spec] Fix spec to work for epel 7
* Add CMake support for python interpreter path
* Add space after if statement
* Fix misc test
* Add missing sentinal
* Add zchunk support to mergerepo_c for extra files

- [boo#1125044] fix for huge rpm packages


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:C as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:C"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:C"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:C got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:C got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:C got accepted.

openSUSE Build Service is sponsored by