I think it would be much clearer to replace the condition

%if 0%{?suse_version} > 1500

and the comment to explain the reason of that check with the proper way to check exactly what we want to check with the following condition instead:

%if %{pkg_vcmp swig >= 4}

I don't think we decided to enforce pkg_vcmp when possible, so I'll accept the SR anyway, but please, consider using it.

Antonio Larrosa (alarrosa) - over 4 years ago

reviewer

Btw, if you also need to support older openSUSE distributions that don't have a pkg_vcmp macro, you can use:

if %{?pkg_vcmp:%{pkg_vcmp swig >= 4}}%{!?pkg_vcmp:0}