Overview
Request 718735 superseded
submit o2locktop package for inital version
- Created by ganghe
- In state superseded
- Supersedes 718439
- Superseded by 718769
- Open review for openSUSE:Factory:Staging:adi:28
-
Open review for
opensuse-review-team
+BuildRequires: python
Do we really want to introduce new python2 code? Py2 is dead.. please port this application to python3
Hello Dimstar,
Since we want to use o2locktop(only python scripts) in different distributions (from SLE11sp4 to SLE12/SLE15, and TW), we should depend on Python or other words? as you know, in some distributions, there is only python2?
Thanks Gang
IIRC, SLE11 had no python3 yet - SLE12 and up have py3
Python2 is declared end-of-life per Jan 1, 2020 (so less than 6 months)
See https://pythonclock.org/ (which is why I believe the TW package and wherever it is introduced with py3 available, must be py3.
Hello Dimstar, please see my new request https://build.opensuse.org/request/show/718735
Thanks Gang
Request History
ganghe created request
submit o2locktop package for inital version
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:28"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:28
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
superseded by 718769
+%doc COPYING => must be %license COPYING (possibly not for SLE11, as that was not supported there)
Hello Dimstar, how do I change this part code for handle all cases? The diff looks like?
-%doc COPYING README.md DESIGN.md
%if 0%{?suse_version} >= 1200 %license COPYING %else %doc COPYING %endif %doc README.md DESIGN.md
right?
Thanks Gang
yes, that should be all right
Thanks, please see the new request https://build.opensuse.org/request/show/718769
The diff looks like, -%doc COPYING README.md DESIGN.md +%if 0%{?suse_version} >= 1200 +%license COPYING +%else +%doc COPYING +%endif +%doc README.md DESIGN.md