Overview
lib/animation.vala is GPL-3.0-only, the license shall be changed to "GPL-3.0-or-later AND GPL-3.0-only".
The parameters used on the %cmake line are also not useful. The %cmake macro already defines the compiler flags and CMAKE_INSTALL_DIR is not needed by deepin-terminal.
You can also change 'make %{?_smp_mflags}' → '%cmake_build'
Request History
hillwood created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:151"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:151
dimstar accepted review
licensedigger accepted review
ok
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
