My original code was designed so that when the LICENSE file arrives in a new tarball we would no longer overwrite it with the local copy. Here this is getting changed to an exit 1 without any echo or comment for other contributors to understand.

The exit 1 is there to let potential contributor know that he can remove extra sources from the package altogether, so we do not ship them forewer. Do you want to revert to the original version?

Andreas Färber (a_faerber) - almost 5 years ago

target maintainer

No, I'm suggesting you amend it so that the build log actually says what the problem is (... && (echo "Conflicting files in tarball, did you forget to update the spec file?"; exit 1;)?) or alternatively to add a comment before that line indicating something like "# TODO remove me once an updated tarball including these files is available". Doing it with three conditional cp operations is hopefully unnecessary.

Apologize, I just submitted the version with the revert to original behaviour.