Overview

Request 698150 accepted

- Remove enum34 dependency from code
- Fix the package license to be in synch with repo license.
- Improved the use of keystore access. When the key_name is informed,
the user_name/user_password is not needed.
- Fix UT to check the inst formatting correctly
- Move the comment to the right place
- Enforce the HANA instance nr format.
- Forces Intance nr always with 2 positions filled with 0
- Forces right formating on HANA OS admin user.
- First package version


Jan Engelhardt's avatar

There ought to be a _service file or a http*-based URL in Source:.


Diego Vinicius Akechi's avatar

Is it mandatory to use the _service file? We are using a similar approach as the YaST package, and the RPM files are being maintained on the github project and are automatically submitted to our Factory development project.


Jan Engelhardt's avatar

You can use a HTTP URL. Github provides a suitable one for tags - so all you need to do is make a git tag for the commit when you bump the version.

Request History
Diego Vinicius Akechi's avatar

dakechi created request

- Remove enum34 dependency from code
- Fix the package license to be in synch with repo license.
- Improved the use of keystore access. When the key_name is informed,
the user_name/user_password is not needed.
- Fix UT to check the inst formatting correctly
- Move the comment to the right place
- Enforce the HANA instance nr format.
- Forces Intance nr always with 2 positions filled with 0
- Forces right formating on HANA OS admin user.
- First package version


Saul Goodman's avatar

licensedigger accepted review

ok


Yuchen Lin's avatar

maxlin_factory added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:158"


Yuchen Lin's avatar

maxlin_factory accepted review

Picked openSUSE:Factory:Staging:adi:158


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by