Overview

Request 690890 accepted

- Drop manual requires from libqb-tests.
- Let libqb-devel depend on the exact package, libqb20 not just
a virtual libqb provide.
- Drop redundant %if..%endif guards that do not affect the build.

- Update to version 1.0.3+20190326.a521604:
- enable building / shipping of libqb-tests.rpm (bsc#1131328)

Loading...

Dominique Leuenberger's avatar

That virtual provides was also used by other packages, like e.g

can't install pacemaker-2.0.1+20190304.9e909a5bd-3.9.x86_64:
  nothing provides libqb > 0.13.0 needed by pacemaker-2.0.1+20190304.9e909a5bd-3.9.x86_64

Jan Engelhardt's avatar

Bleh. We need to come up with a better provides name for these things. Does featurelevel(libqb) = 0.13.0 sound like a sellable idea?


Yan Gao's avatar
author source maintainer

I'm dropping the the unnecessary virtual dependency from pacemaker.


Yan Gao's avatar
author source maintainer

Dropped the dependency from pacemaker considering the fact that there are not likely libqb versions < 0.13.0 nowadays: https://build.opensuse.org/request/show/691524

, although I don't understand the problem of using "Provides".


Dominique Leuenberger's avatar

Symbol Versioning for the world! I wish it was easier to convince upstreams to do so


Jan Engelhardt's avatar

Symbol versioning only helps with ABI/API, but does not for behavioral changes of a function.


Yan Gao's avatar
author source maintainer

BTW, I went through all the other consumers of libqb and didn't find anything else using the virtual provides.

Request History
Yan Gao's avatar

yan_gao created request

- Drop manual requires from libqb-tests.
- Let libqb-devel depend on the exact package, libqb20 not just
a virtual libqb provide.
- Drop redundant %if..%endif guards that do not affect the build.

- Update to version 1.0.3+20190326.a521604:
- enable building / shipping of libqb-tests.rpm (bsc#1131328)


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:F


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse approved review

ready to accept


Dominique Leuenberger's avatar

dimstar_suse accepted request

Accept to openSUSE:Factory

openSUSE Build Service is sponsored by