Request 664676 (accepted)

No description set

reviewer source maintainer

I do not see a need to ship the entire source -- if Go depends on protobuf definitions, should the .pb files not be enough?

author reviewer

Unfortunately not. Please see the comments here - https://build.opensuse.org/request/show/664397

Bazel also requires BUILD files and expects the whole source tree to be present.

See also the patch in which I made to point envoy to protobufs shipped in packages. I needed to point Bazel to the whole source tree. I didn't find any other way to do that. https://build.opensuse.org/package/view_file/home:mrostecki/envoy-proxy/envoy-proxy-unbundle-dependencies.patch?expand=1

staging-bot added openSUSE:Factory:Staging:adi:18 as a reviewer over 5 years ago

Being evaluated by staging project "openSUSE:Factory:Staging:adi:18"

Picked openSUSE:Factory:Staging:adi:18

factory-auto added opensuse-review-team as a reviewer over 5 years ago

Please review sources

factory-auto added repo-checker as a reviewer over 5 years ago

Please review build success

Check script succeeded

jengelh added mrostecki as a reviewer over 5 years ago

Not sure why I even can review my own request, but... well... looks good to me?

cycle and install check passed

ready to accept

ready to accept

Accept to openSUSE:Factory