Overview
Request 629485 accepted
- Merge -kubic packages back into the main Virtualization:containers packages.
This is done using _multibuild to add a "kubic" flavour, which is then used
to conditionally compile patches and other kubic-specific features.
bsc#1105000
Loading...
Request History
cyphar created request
- Merge -kubic packages back into the main Virtualization:containers packages.
This is done using _multibuild to add a "kubic" flavour, which is then used
to conditionally compile patches and other kubic-specific features.
bsc#1105000
cyphar accepted request
LGTM. Not forwarding to factory until I message DimStar about it.
We can't really accept this until we figure out how we are going to coordinate it with the removal of the -kubic packages.
@RBrownSUSE -- any suggestion on how we should handle the removal+addition of packages in Factory without having a breakage in the middle? Should we ping Dominique via email beforehand?
I don't see the problem - you should be able to send a docker-kubic drop request at the same time as this submission..and should be able to tell the reviewers that they need to be staged together
However, this submission doesn't include my proposed changes to docker-kubic, which are needed for docker to be actually usable as a CRI runtime on new kubic..so you probably want to correct that :)
Also (as questioned on IRC) - how is build_flavour meant to work on Tumbleweed Kubic?
Kubic does not have separate repositories or a build target.. so build_flavour is not an option we can ever consider for Kubic
Tehrefore, unless I'm miss reading this submission, this will never produce a -kubic package for kubic..ironically
_multibuild is automatically handled by OBS -- so any project that has these packages will build both flavours automatically (you can take a look at my home project to see what it looks like -- you can also see in the sidebar that there is this weird containerd:kubic thing going on).
So once this is in Factory it will build both docker.rpm and docker-kubic.rpm from the same OBS package. And the _product definitions should stop people from seeing both docker and docker-kubic in SLE (for instance).
As for your proposed changes, I was hoping to submit this immediately and then I could rebase your proposed changes (since you asked us not to push them to Factory).
ok then :)
@cyphar, @jordimassaguerpla: review reminder